Upgrade erusev/parsedown from 1.7.4 to 1.8.0#704
Merged
mikelittle merged 1 commit intomasterfrom Feb 28, 2026
Merged
Conversation
Update the parsedown dependency to the latest stable release (1.8.0) which includes security fixes and improved CommonMark compliance. Update MarkdownParser::blockHeader() to use the 1.8.0 element structure where handler is now an array with function/argument/destination keys, and child elements use the 'elements' key directly. This also fixes a pre-existing bug where header anchor IDs were empty because sanitize_title_with_dashes() was processing raw Parsedown inline tokens instead of plain text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Some before and after images after: 
|
mikelittle
requested review from
ajvillegas,
ferschubert-hm,
filter182,
jerico,
vladislavhmn and
wisyhambolu
joehoyle
approved these changes
Feb 28, 2026
|
Successfully created backport PR for |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin v12-branch
git worktree add -d .worktree/backport-704-to-v12-branch origin/v12-branch
cd .worktree/backport-704-to-v12-branch
git switch --create backport-704-to-v12-branch
git cherry-pick -x f698bcbdd7ae0c6f0b7fc500657d6ca3144a7e3f |
mikelittle
added
backport v23-branch
backport v24-branch
backport v25-branch
and removed
backport v12-branch
labels
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
After resolving conflicts, continue with:# Add the resolved files
git add .
# Continue the cherry-pick
git cherry-pick --continue
# Push the branch to GitHub
git push --set-upstream origin backport-704-to-v12-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktree/backport-704-to-v12-branchThen create a pull request using the GitHub CLI: gh pr create --base v12-branch --head backport-704-to-v12-branch --title "[Backport v12-branch] Upgrade erusev/parsedown from 1.7.4 to 1.8.0" --body "Backport of #704 to \`v12-branch\`." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apropros this Dependabot PR which was closed, because this is master and there are security fixes, I looked into it.
erusev/parsedownfrom~1.7.4to~1.8.0, the first stable release in 6+ years, which includes security fixes (catastrophic backtracking prevention) and improved CommonMark complianceMarkdownParser::blockHeader()to use the 1.8.0 element structure wherehandleris now an array withfunction/argument/destinationkeys, and child elements use theelementskey directlyhref="#" id="") becausesanitize_title_with_dashes()was processing raw Parsedown inline tokens instead of plain text — 1.8.0'shandler['argument']provides clean text, so anchors now render correctlyTest plan
🤖 Generated with Claude Code